Skip to content

Check clipping before recording hits on text nodes #22510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alice-i-cecile merged 3 commits into from
Jan 14, 2026
Merged

Check clipping before recording hits on text nodes #22510

alice-i-cecile merged 3 commits into from
Jan 14, 2026

Conversation

@ickshonpe
Copy link
Contributor

@ickshonpe ickshonpe commented Jan 14, 2026 •
edited
Loading

Objective

Fixes #22507

Solution

Call clip_check_recursive when checking text nodes for pointer hits.

Testing

Made a branch of bevy_immediate using this fix, as @PPakalns suggested:
https://github.com/ickshonpe/bevy_immediate/tree/text-picking-clip-fix

Then

cargo run --example demo

and select "Bevy Scrollareas" from the menu on the left.

You should see that scrolling the scrollable areas to the right no longer blocks interactions with the menu.

@ickshonpe ickshonpe added this to the 0.18.1 milestone Jan 14, 2026
@ickshonpe ickshonpe added A-UI Graphical user interfaces, styles, layouts, and widgets A-Text Rendering and layout for characters A-Picking Pointing at and selecting objects of all sorts C-Bug An unexpected or incorrect behavior D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jan 14, 2026
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jan 14, 2026
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jan 14, 2026
Merged via the queue into bevyengine:main with commit 1b1458c Jan 14, 2026
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@viridia viridia viridia approved these changes

@mardzie mardzie mardzie approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-Picking Pointing at and selecting objects of all sorts A-Text Rendering and layout for characters A-UI Graphical user interfaces, styles, layouts, and widgets C-Bug An unexpected or incorrect behavior D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Milestone

0.18.1

Development

Successfully merging this pull request may close these issues.

UI picking regression: doesn't correctly work when overflow: scroll clipped text content is on top of other content

4 participants

@ickshonpe @viridia @mardzie @alice-i-cecile